Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Effect in How it Works #464

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Added Effect in How it Works #464

merged 4 commits into from
Jul 19, 2024

Conversation

zalabhavy
Copy link
Contributor

Pull Request

Title

Add loading when scroll effects on about page's true marks.

Description

Added Effect like Home page right tick text in about's how it works section text.

Related Issues

Fixes #451

Changes Made

Added Effects in About Page

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

https://www.loom.com/share/e07e8e5c0f9b42e1bd71d36e98c0ba39

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 0:10am

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

VaibhavArora314
VaibhavArora314 reviewed Jul 18, 2024
View reviewed changes
Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just remove react import
image

@zalabhavy
Copy link
Contributor Author

@VaibhavArora314 @akbatra567 React import removed !
Please check it and merge !

Thank You !

VaibhavArora314
VaibhavArora314 requested changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the animation looks good but a minor change is needed, when the items show up one by one they push the previous one up

@zalabhavy
Copy link
Contributor Author

@VaibhavArora314 Done !
https://www.loom.com/share/52a8830b32534449bdd9be681e978bae

@akbatra567 akbatra567 merged commit 055472e into VaibhavArora314:main Jul 19, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@zalabhavy
Copy link
Contributor Author

@VaibhavArora314 @Ultimateutkarsh11 @akbatra567 please also provide label !

Thank You !

@zalabhavy
Copy link
Contributor Author

@VaibhavArora314 level2 Please !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ultimateutkarsh11 Ultimateutkarsh11 Ultimateutkarsh11 approved these changes

@VaibhavArora314 VaibhavArora314 VaibhavArora314 approved these changes

@akbatra567 akbatra567 akbatra567 approved these changes

Assignees

@zalabhavy zalabhavy

Labels
gssoc GSSOC level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add loading when scroll effects on about page's true marks
4 participants
@zalabhavy @akbatra567 @VaibhavArora314 @Ultimateutkarsh11