Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Modified the whole navbar and adjust the google translator button successfully issue 462 #467

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 19, 2024

Pull Request Resolves [#462 ]

Title: Modified the whole navbar and adjust the google translator button successfully.

Description

  1. I Changed the whole navbar and specially the added the user image and below it there is a dropdown like most of the webapps have nowadays.
  2. The design is responsive in all the devices and can work in both light/dark mode.
  3. Removed the white space also.
  4. Add google translator in fixed positon.
  5. If added in navbar it will lead to problem.

Related Issues

Changes Made

Bug fixes: Modified the whole navbar and adjust the google translator button.

Screenshots

image

image

image

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 7:02am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but after login I am still seeing options of signin and signup in mobile view
image

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 20, 2024

Looking good but after login I am still seeing options of signin and signup in mobile view image

OOPs I forgot to add that isLogged in condition, I will fix it 👍

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 20, 2024

@VaibhavArora314 check now 😀

@Ultimateutkarsh11 Ultimateutkarsh11 merged commit fc6d000 into VaibhavArora314:main Jul 21, 2024
3 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@Ultimateutkarsh11 Ultimateutkarsh11 added bug Something isn't working level1 labels Jul 21, 2024
@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 21, 2024

@Ultimateutkarsh11 please add level 2 because I have to do navbar from scratch that's why !

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 21, 2024

@VaibhavArora314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc GSSOC level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants