Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Make the post card clickable #482

Merged
merged 2 commits into from
Jul 23, 2024
Merged

FIX: Make the post card clickable #482

merged 2 commits into from
Jul 23, 2024

Conversation

Vaibhav-kesarwani
Copy link
Contributor

@Vaibhav-kesarwani Vaibhav-kesarwani commented Jul 22, 2024 •
edited
Loading

Pull Request Resolves [#350]

Title

Make the postcard clickable.

Description

When we hover over the card, it appears as though we can click anywhere on it, and clicking takes us straight to the read more page.

Related Issues

Fixes #350

Changes Made

Make the postcard clickable

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

Screencast.from.22-07-24.10.53.56.PM.IST.webm

Additional Notes

By submitting this pull request, I attest that I have complied with the applicable code of conduct and supplied the necessary screenshot for verification.

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 5:58am

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Vaibhav-kesarwani
Copy link
Contributor Author

@VaibhavArora314 @akbatra567 @Ultimateutkarsh11 Please check it and merge !

Thank You !

VaibhavArora314
VaibhavArora314 requested changes Jul 23, 2024
View reviewed changes
Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
we can remove the read more button since the whole card is clickable now

@Vaibhav-kesarwani
Copy link
Contributor Author

ok, sure!

@Vaibhav-kesarwani
Copy link
Contributor Author

Screenshot from 2024-07-23 11-26-46

Done

@akbatra567 akbatra567 merged commit 87fa5e3 into VaibhavArora314:main Jul 23, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ultimateutkarsh11 Ultimateutkarsh11 Ultimateutkarsh11 approved these changes

@VaibhavArora314 VaibhavArora314 VaibhavArora314 approved these changes

@akbatra567 akbatra567 akbatra567 approved these changes

Assignees

@Vaibhav-kesarwani Vaibhav-kesarwani

Labels
gssoc GSSOC level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX Change] Make the Post Card Clickable
4 participants
@Vaibhav-kesarwani @akbatra567 @VaibhavArora314 @Ultimateutkarsh11