Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added preloader in style share successfully issue 412 #515

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 27, 2024

Pull Request resolves [ #412 ]

Title: Added preloader in style share successfully.

Description

  1. In frontend, I set the timmer for 5 second so that the animation fully completed.
  2. I created 2 files i.e Preloader.tsx and its .css.
  3. The design is responsive.

Related Issues

Fixes #412

Changes Made

New feature: Added preloader in style share.

Screenshots

image

Video

Style.Share._.Welcome.-.Google.Chrome.2024-07-27.14-43-31.online-video-cutter.com.mp4

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 11:52am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just one thing can most of the styling be implemented using tailwind to maintain consistency

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 27, 2024

Great work, just one thing can most of the styling be implemented using tailwind to maintain consistency

Okay I will figure it out I will use as much as tailwind css only to stick to consistency of style share !

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 27, 2024

@VaibhavArora314 Done !

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 27, 2024

@Ultimateutkarsh11 please give level 2 if possible after complete evaluation 👍

@Ultimateutkarsh11 Ultimateutkarsh11 merged commit ed8d531 into VaibhavArora314:main Jul 27, 2024
3 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@Ultimateutkarsh11 Ultimateutkarsh11 added level2 enhancement New feature or request labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GSSOC level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding preloader to the website.
4 participants