Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added/fetched user avatar in admin panel successfully issue 548 #551

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Aug 1, 2024

Pull Request Resolves [ #548 ]

Title: Added/fetched user avatar in admin panel successfully.

Description

  1. In backend, for every controller I have added avatar:true to fetch in the admin panel.
  2. In assests, I added the image to get /admin/... and replace it with the /app/...
  3. In admin, I am fetching the avatar url from api created.
  4. The design is responsive.

Related Issues

Fixes #548

Changes Made

New feature: Added/fetched user avatar in admin panel.

Screenshots

image

image

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 10:45am

Copy link

github-actions bot commented Aug 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of replacing the whole string why don't we just replace admin with app?

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Aug 2, 2024

@VaibhavArora314 I think this will make negligible difference, but never mind I did the changes as you told me 👍

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Aug 2, 2024

@VaibhavArora314 please give level 2 if possible 👍

@VaibhavArora314
Copy link
Owner

@VaibhavArora314 please give level 2 if possible 👍

I think there was not too much work in this one and it should be under level 1.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Aug 2, 2024

@VaibhavArora314 please give level 2 if possible 👍

I think there was not too much work in this one and it should be under level 1.

😭 bro they just change margin bottom and get level 1, then what is the difference between them and me ?

@VaibhavArora314
Copy link
Owner

@VaibhavArora314 please give level 2 if possible 👍

I think there was not too much work in this one and it should be under level 1.

😭 bro they just change margin bottom and get level 1, then what is the difference between them and me ?

You got a point

@VaibhavArora314 VaibhavArora314 merged commit 3ba5b99 into VaibhavArora314:main Aug 3, 2024
3 checks passed
Copy link

github-actions bot commented Aug 3, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Showing user avatar in all tables in admin panel
3 participants