Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a single button #563

Closed
wants to merge 2 commits into from
Closed

Conversation

lolpanda2004
Copy link
Contributor

@lolpanda2004 lolpanda2004 commented Aug 4, 2024

Pull Request

Title

Merged Sign in and Sign up

Description

merged two seperate button as one and made it easier for users to understand where they can access the log in and sign up page.

Related Issues

Fixes #523

Changes Made

Made changes in the navbar.tsx and deleted one button and made changes to the other.

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

register

Additional Notes

Footer

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 3:06am

Copy link

github-actions bot commented Aug 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@lolpanda2004
Copy link
Contributor Author

@VaibhavArora314 do check if this looks better

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than register, write login/signin since we are redirecting to signin page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Merging the sign in and signup button as a single button
2 participants