feat: Added Pagination posts section successfully Issue 40 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
MeetDOD
changed the title
VaibhavArora314
requested changes
Jun 1, 2024
There was a problem hiding this comment.
resolve merge conflicts, ui looks good to me
also, can you increase posts per page to 12 as for medium devices 2 are supposed to come in a row so the last post is alone in a row
also can you move the pagination logic to the backend as the no of posts increase it will increase client load to fetch all together
|
Ok i will do it @VaibhavArora314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Resolves[#40]
Title: Applied Pagination in Style Share webapp Successfully.
Description:
I had created a hook name currentPage and setcurrentPage which will change the number of posts with the const postsPerPage = 9.
I had created handlePreviousPage which will decrement by - 1 and handleNextPage which will increment by + 1 per posts.
Applied with filteredPosts.
Related Issues
Fixes #40
Changes Made
new feature introduced as pagination in posts page.
Screenshots
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.