Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bookmark feature to posts #61

Closed
wants to merge 1 commit into from

Conversation

ISHITA1004
Copy link

@ISHITA1004 ISHITA1004 commented Jun 1, 2024

  • Implement bookmark button component
  • Integrate bookmark functionality in Posts and PostCard components
  • Add bookmark list page to view all bookmarked posts
  • Include state management for bookmarks using useState
  • Update routes in App component to include /app/bookmarks
  • Ensure posts can be filtered by tags with the new filter dialog
  • Improve UX with conditional rendering of loader and error messages

Pull Request

Title

Description

Related Issues

Changes Made

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

Additional Notes

Footer

- Implement bookmark button component
- Integrate bookmark functionality in Posts and PostCard components
- Add bookmark list page to view all bookmarked posts
- Include state management for bookmarks using useState
- Update routes in App component to include /app/bookmarks
- Ensure posts can be filtered by tags with the new filter dialog
- Improve UX with conditional rendering of loader and error messages
Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ❌ Failed (Inspect) Jun 1, 2024 8:18am

Copy link

github-actions bot commented Jun 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@VaibhavArora314
Copy link
Owner

image

also, move the bookmark logic to the backend as reloading frontend will cause a loss of bookmarks

@ISHITA1004
Copy link
Author

ISHITA1004 commented Jun 1, 2024 via email

@VaibhavArora314
Copy link
Owner

@ISHITA1004 any updates?

@MeetDOD
Copy link
Contributor

MeetDOD commented Jun 4, 2024

@VaibhavArora314 is anybody is doing this feature ? or i will implement it ! assign it to me if possible :)

@VaibhavArora314
Copy link
Owner

@VaibhavArora314 is anybody is doing this feature ? or i will implement it ! assign it to me if possible :)

let's wait for one day more, if there is no response from @ISHITA1004 then I will assign you the corresponding issue and close this PR.

@MeetDOD
Copy link
Contributor

MeetDOD commented Jun 4, 2024

ok understood .

@VaibhavArora314
Copy link
Owner

due to inactivity, closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants