Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added syntax highlighting in post #82

Closed
wants to merge 16 commits into from
Closed

Added syntax highlighting in post #82

wants to merge 16 commits into from

Conversation

Joyosmit
Copy link
Contributor

@Joyosmit Joyosmit commented Jun 2, 2024

Pull Request

Title

Added syntax highlighting in the post

Fixes : #80

Changes Made

  1. Used react-syntax-highlighter for syntax highlighting
  2. Changed code in Post.tsx

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots

AA2211

@vercel Vercel
Copy link

vercel bot commented Jun 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:01am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Joyosmit
Copy link
Contributor Author

Joyosmit commented Jun 2, 2024

Pls add the gssoc label and level1/2/3 label

VaibhavArora314
VaibhavArora314 requested changes Jun 2, 2024
View reviewed changes
Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove comments from sendWelcomeMail.ts
  2. remove console.log from signup
  3. resolve merge conflicts

@VaibhavArora314
Copy link
Owner

The deployment keeps failing, please check

@Joyosmit
Copy link
Contributor Author

Joyosmit commented Jun 3, 2024

Is there any way to check the deployment logs of someone else?

@VaibhavArora314
Copy link
Owner

Is there any way to check the deployment logs of someone else?

image

@Joyosmit
Copy link
Contributor Author

Joyosmit commented Jun 3, 2024

Fixed the deployment issue

@VaibhavArora314
Copy link
Owner

everything is good but why code section is shown 2 times
image

@VaibhavArora314
Copy link
Owner

ok, so the original functionality was that when preview button is pressed preview is shown then we can see code back by pressing show code
image
image

now in your changes, when preview button is pressed preview is shown separately and show code option is also shown even when code is shown
image
image

@VaibhavArora314
Copy link
Owner

in short, I want you to show a code window where syntax-highlighted code is shown, when the user clicks the preview button then code is hidden and the preview is shown. after that when the show code is pressed then code is shown again and the preview is hidden.

also delete package-lock.json from root of folder

@VaibhavArora314
Copy link
Owner

Comment axios defaulturl in app.tsx

@VaibhavArora314
Copy link
Owner

closing this pr for now due to so many merge conflicts and confusion, please raise another pr for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaibhavArora314 VaibhavArora314 VaibhavArora314 requested changes

@Ultimateutkarsh11 Ultimateutkarsh11 Ultimateutkarsh11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No syntax highlighting in the code snippet for code
3 participants
@Joyosmit @VaibhavArora314 @Ultimateutkarsh11