Implement support for KV1 binary serialization with string tables #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
reviewed
Jul 2, 2024
| { | ||
| if (reverse is not null) | ||
| { | ||
| return; |
There was a problem hiding this comment.
Is this gonna cause issues if you serialize, change the kv and try to serialize again?
Actually not seeing a way for stringtable to be populated by the seializer.
There was a problem hiding this comment.
oh that's an interesting idea, should we dynamically populate a string table?
There was a problem hiding this comment.
If we want to support serialization, we kind of have to.
There was a problem hiding this comment.
We also need a public accessor to the list if that happens, because you need to store it somehow
|
Apisurface does not seem to dump constructors? |
xPaw
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a different approach to #99.