WaylandBackend: Fix scale equation and unscale libdecor frame commit #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem to fix #1536 for me on Plasma 6.2.3 Wayland. Still a sliver at the very bottom and to the right side at 175% that isn't present at 150% 175%
150%
edit:
|
|
Ah, I didn't read the issue properly sorry. |
This fixes the issue where in a scaled wayland sessions the window buffer is the correct size with window decorations that are too large. It also fixes gamescope being having a couple of pixels smaller when fullscreen.
ColinKinloch
force-pushed
the
fractional_scale_libdecor_fix
branch
from
2f28661 to
6503630
Compare
ColinKinloch
changed the title
|
@matte-schwartz I replicated this today with 105% scaling which was causing the surface to be 1 pixel too small and 1 pixel offset. |
6 tasks
|
@ColinKinloch that does indeed solve #1536 on my end, nice work! |
|
this PR also seems to fix #1620 |
6 tasks
|
Thanks! |
2 tasks
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where in a scaled wayland sessions the window buffer is the correct size with window decorations that are too large.
The frame issue effects compositors that don't support server side decoration.
It also fixes gamescope being having a couple of pixels smaller when fullscreen with 105% scaling.
fixes #1536, fixes #1620