-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steam beta - all Header and Subheader items cannot be clicked/entered #9376
Comments
I can confirm this issue on XMonad. #9392 |
I should have mentioned: I'm also on XMonad. |
On Gnome it also doesn't seem to work, Arch Linux here. |
Subheaders always appear clickable in the Library header and any of its subheaders. But in any of the others, its seemingly random whether they're appear or not. |
only works in KDE; clicks may/may not register on gnome |
the new update seems to have done something. |
The dropdown in the shop navi itself ("your store", …) is unusable, too. The moment I move the mouse off the top-level navigation item, the dropdown vanishes again. |
the new update (1686092969) improved it again, it is still a bit busted, but also usable! |
On latest beta update, not usable for me on XMonad. Whole top two rows are unclickable. |
That's been fixed for me now. 👍 I don't have any issues with the "subheader" or "menu items" on Fedora 38, Gnome with X.org on Nvidia. |
When hovering any of the subheaders or clicking the menu items. They appear for a split second then disappear. Same with right click context menus. |
with a lot of clicking I can get them to appear ( |
@kisak-valve This is now in stable and completely broken, can't even enter steam settings. Control + click does not work. Can we get an update on this? |
I don't see anything in the beta notes, but after the update 10 minutes ago all the popup menus are working perfectly fine now. |
I am fairly sure that popup menus started working few days ago, I think it was one of those "frontend update" that get applied automatically, all you needed to do was to restart client. There are still broken right-click context menus all over the place though (even Friends/Chat), but that probably doesn't belong in this issue. |
I can confirm that everything except right click context menus are working on the beta. |
I can confirm all header and subheader working on Xmonad for me right now (Steam 1687306661). |
The top row menu (Steam View Friends Games Help) stopped recently working again. Context menus just quickly pop up and disappears again, with no chance to click anything. |
Can confirm, latest beta just the top row stopped working again. |
can confirm as well |
Can attest to this being an issue |
Ran into this exact issue while trying to ignore a game from the store. Dropdown on the right of the "ignore" button does appear, but I can't click on any of the two options. This means I can't ignore games I played on other platforms. I use archlinux, latest nvidia drivers, on Xorg with i3 window manager. |
openSUSE with KDE, cannot click any menu items. I don't know which version it is, and I cannot opt into any beta client because that apparently requires clicking the "Steam" menu item which does nothing. |
Issue for me on xmonad 0.18 as well. |
Is it possible to opt out from the new UI and keep the stable one. |
More specifically, ignore ClientMessageEvents for unmanaged windows. Steam likes to send _NET_ACTIVE_WINDOW requests for all its windows, including override-redirect ones, which used to result in an invocation of `windows` with a no-op Endo—equivalent to a call to `refresh`. But this refresh makes Steam close its menus immediately. Fixes: ValveSoftware/steam-for-linux#9376 Related: xmonad/xmonad#451
Here's an xmonad-contrib pull request that fixes the menu issue and also provides a workaround (needs to be explicitly added to Can some people who're affected test this please? |
@liskin I've just tried your patch. It seems to be working, though I didn't check too hard for any undesirable side-effects. The flickering and the resulting slowdowns are both gone. The menus are working too! I'll keep the patched build running for the foreseeable future and report back any regressions I might notice. |
@liskin Seems to work for me as well! I noticed random lagginess in games since I switched to xmonad, I hope this patch also fixes that! Thank you! |
More specifically, ignore ClientMessageEvents for unmanaged windows. Steam likes to send _NET_ACTIVE_WINDOW requests for all its windows, including override-redirect ones, which used to result in an invocation of `windows` with a no-op Endo—equivalent to a call to `refresh`. But this refresh makes Steam close its menus immediately. Fixes: ValveSoftware/steam-for-linux#9376 Fixes: xmonad/xmonad#451
@liskin thank you, this worked for me too! |
Works for me as well, and I have not noticed any regressions so far. |
Can someone share their |
@hjpaul7 Just to be clear, you need to apply the linked patch to your
import XMonad.Util.Hacks (fixSteamFlicker)
handleEventHook = handleEventHook baseConfig …into: handleEventHook = fixSteamFlicker <+> handleEventHook baseConfig |
@liskin Hello, not sure if the patch was meant to fix this issue as well, but I am still getting some flickering specifically when steam toasts slide away (the "someone is online" notifications). I probably will just disable these, but I wanted to let you know in case your patch was meant as a fix for this flickering. It is strange because I thought I noticed this was fixed at first, but it seems to come back in certain situations. Will try to reproduce specifically (unless your patch wasn't meant to fix this) |
Yup I just wanted to make sure I had the import and eventHook correct. Wow, that works so well and makes Steam actually usable. |
It's something that I'd expect to be fixed provided you have map toLower `fmap` className =? "steam" You can try https://xmonad.github.io/xmonad-docs/xmonad-contrib-0.18.0.9/XMonad-Hooks-DebugEvents.html#v:debugEventsHook in your config and then you'll be looking for suspicious (large amounts of, due to the sliding effect) ConfigureRequest events. We might need to add another query for these toast windows, or perhaps Steam fails to mark them as override-redirect and then we'd need a ManageHook that matches these and does (Personally I do disable all these notifications but if nobody else figures it out I might try turning them on temporarily and see what happens. It's not a priority, though, to be entirely honest.) |
This seems to be the
If I read this correctly, then it seems steam doesn't send a |
xmonad doesn't react to But… if that's all that's happening, I wouldn't expect any flickering. Can you confirm those notification toasts have no borders? And elaborate where exactly you're seeing the flicker? |
I have looked a bit further into this, and indeed it seems that these notification toasts don't cause flickering. I was sure I had encountered some flickering after applying the patch, but so far, I have not been able to observe it anymore after enabling the debug logging. Edit: Now that I've taken out the |
I have finally managed to capture the debug output of a flicker-triggering notification. The notification toasts do not have borders (they never had, as far as I can remember). What flickers is the foreground window (in this case, emacs), over which the notification toast was drawn.
|
@mmarx Hm, nothing in there looks suspicious at a glance. Can you perhaps elaborate on which parts of this are repeating while the flicker is going on? Or is this whole thing repeating in the logs? (Also, which part of emacs flickers? The border or just the inside of the window?) |
The only repeating parts are the |
Hm, flickering of emacs' insides shouldn't be related to xmonad… It could just be that the notification toasts are moving around and emacs struggles to keep up redrawing. Are you running a compositor (xcompmgr, compton, picom, something like that)? I'm only seeing Expose events (those cause the insides of a window to get redrawn) if I disable compositing, otherwise windows have backing stores and don't need to be redrawn when windows above them get moved around. |
I do run picom. Since it's been so hard to reproduce the flickering, this might indeed be related to emacs. I'm not sure how to debug this further, though. |
More specifically, ignore ClientMessageEvents for unmanaged windows. Steam likes to send _NET_ACTIVE_WINDOW requests for all its windows, including override-redirect ones, which used to result in an invocation of `windows` with a no-op Endo—equivalent to a call to `refresh`. But this refresh makes Steam close its menus immediately. Fixes: ValveSoftware/steam-for-linux#9376 Fixes: xmonad/xmonad#451
Is this still an issue? |
Yes, I still have this issue. Clicking on a menu at the top of the screen (Steam or View) briefly shows the menu, but then it disappears. Holding down the mouse button doesn't help, nor does holding Ctrl. So I have no means to select anything from any of the top menus. I'm on:
|
What version of xmonad? We |
Your system information
Please describe your issue in as much detail as possible:
Every item in the header/toolbar in the new beta client cannot be clicked (any form of dropdown). The dropdown appears for a split second and then disappears. Cannot access any menu, such as settings to revert beta. This includes these items in the header:
Subheader (can be clicked, but same behavior for dropdowns):
Steps for reproducing this issue:
2023-04-27.23-21-47.mp4
Edit: During recording the screencast some of the dropdowns started working, no idea why. Soon as I stopped though they went back to never showing up.
The text was updated successfully, but these errors were encountered: