Skip to content

Commit

Permalink
1.13.1 (#550)
Browse files Browse the repository at this point in the history
* Remove log warning for known cases of wrong FW strings (#539)

* Bump actions/checkout from 4.1.7 to 4.2.0 (#540)

* Bump codecov/codecov-action from 4.5.0 to 4.6.0 (#542)

* Bump actions/upload-artifact from 4.4.0 to 4.4.3 (#546)

* Bump actions/checkout from 4.2.0 to 4.2.1 (#543)

* Bump actions/checkout from 4.2.1 to 4.2.2 (#547)

* Bump actions/setup-python from 5.2.0 to 5.3.0 (#548)

* Bump version to `1.13.1`

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
Vaskivskyi and dependabot[bot] authored Nov 10, 2024
1 parent e2a1e0d commit 4d9e324
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 14 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
pip_cache_dir: ${{ steps.pip-cache.outputs.dir }}
steps:
- name: Checkout
uses: actions/checkout@v4.1.7
uses: actions/checkout@v4.2.2

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5.2.0
uses: actions/setup-python@v5.3.0
with:
python-version: ${{ matrix.python-version }}

Expand Down Expand Up @@ -60,10 +60,10 @@ jobs:
python-version: [3.11, 3.12]
steps:
- name: Checkout
uses: actions/checkout@v4.1.7
uses: actions/checkout@v4.2.2

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5.2.0
uses: actions/setup-python@v5.3.0
with:
python-version: ${{ matrix.python-version }}

Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
pytest --cov=asusrouter --cov-report=xml:unit-tests-cov-${{ matrix.python-version }}.xml -k 'not test_devices'
- name: Upload coverage to artifacts
uses: actions/[email protected].0
uses: actions/[email protected].3
with:
name: unit-tests-cov-${{ matrix.python-version }}
path: unit-tests-cov-${{ matrix.python-version }}.xml
Expand All @@ -106,10 +106,10 @@ jobs:
python-version: [3.11, 3.12]
steps:
- name: Checkout
uses: actions/checkout@v4.1.7
uses: actions/checkout@v4.2.2

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5.2.0
uses: actions/setup-python@v5.3.0
with:
python-version: ${{ matrix.python-version }}

Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
pytest --cov=asusrouter --cov-report=xml:real-data-tests-cov-${{ matrix.python-version }}.xml tests/test_devices.py --log-cli-level=INFO
- name: Upload coverage to artifacts
uses: actions/[email protected].0
uses: actions/[email protected].3
with:
name: real-data-tests-cov-${{ matrix.python-version }}
path: real-data-tests-cov-${{ matrix.python-version }}.xml
Expand All @@ -152,7 +152,7 @@ jobs:
python-version: [3.11, 3.12]
steps:
- name: Checkout
uses: actions/checkout@v4.1.7
uses: actions/checkout@v4.2.2

- name: Download unit-tests coverage from artifacts
uses: actions/[email protected]
Expand All @@ -167,7 +167,7 @@ jobs:
path: .

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4.5.0
uses: codecov/codecov-action@v4.6.0
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:

steps:
- name: Checkout the repository
uses: actions/checkout@v4.1.7
uses: actions/checkout@v4.2.2
with:
ref: ${{ github.event.release.target_commitish }}

- name: Setup Python ${{ env.DEFAULT_PYTHON }}
uses: actions/setup-python@v5.2.0
uses: actions/setup-python@v5.3.0
with:
python-version: ${{ env.DEFAULT_PYTHON }}

Expand Down
6 changes: 5 additions & 1 deletion asusrouter/modules/firmware.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,11 @@ def from_string(self, fw_string: Optional[str] = None) -> None:

fw_string = clean_string(fw_string)
if not fw_string:
return
return None

# Special cases for old firmwares and absent data
if fw_string == "__":
return None

pattern = (
r"^(?P<major>[39].?0.?0.?[46])?[_.]?"
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "asusrouter"
version = "1.13.0"
version = "1.13.1"
license = {text = "Apache-2.0"}
requires-python = ">=3.11.0"
readme = "README.md"
Expand Down
1 change: 1 addition & 0 deletions tests/modules/test_firmware.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ def test_update_source(self, revision, expected_source):
),
# Additional cases
(".386.7_120", None, 386, 7, 120, False, False),
("__", None, None, None, None, False, False),
# Invalid input
("", None, None, None, None, False, False),
("invalid", None, None, None, None, False, False),
Expand Down

0 comments on commit 4d9e324

Please sign in to comment.