Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the tilib implementation #31

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

Expand the tilib implementation #31

wants to merge 46 commits into from

Conversation

@rbran rbran changed the title Innerref tilib Expand the tilib implementation Dec 31, 2024
@rbran
Copy link
Collaborator Author

rbran commented Jan 9, 2025

I included a "permissive" feature, it allows unknown flags and adopts a more "forgiven" parsing process.

It could be used in binary ninja to avoid errors happening, but doing so will also makes the development of this create a little harder, because we want to identify files that include unknown flags or different encodings.

rbran added 2 commits January 10, 2025 07:38
Tests usually use the --all-features to make more complete coverage.

Because not having the "permissive" feature is more likelly to causes
errors, having it replaced with "restrictive" feature create better
tests.
@rbran
Copy link
Collaborator Author

rbran commented Jan 10, 2025

I changed the "permissive" feature into a "restrictive" feature, it's a better idea because most tests run with cargo test --all-features by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant