-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the tilib implementation #31
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 7c91b3a.
The permissive feature will make allow a more "relaxed" parsing of files, making fewer checks and defaulting to 0 if EoF is found.
I included a "permissive" feature, it allows unknown flags and adopts a more "forgiven" parsing process. It could be used in binary ninja to avoid errors happening, but doing so will also makes the development of this create a little harder, because we want to identify files that include unknown flags or different encodings. |
Tests usually use the --all-features to make more complete coverage. Because not having the "permissive" feature is more likelly to causes errors, having it replaced with "restrictive" feature create better tests.
I changed the "permissive" feature into a "restrictive" feature, it's a better idea because most tests run with |
TODO: