Add early stop module #301
Merged
+647
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4Health into sa_early_stop
for more information, see https://pre-commit.ci
sanaAyrml
commented
Jan 9, 2025
emersodb
reviewed
Jan 9, 2025
nerdai
reviewed
Jan 14, 2025
fl4health/utils/early_stopper.py
Outdated
| self.best_score: float | None = None | ||
| self.snapshot_ckpt: dict[str, Any] = {} | ||
|
|
||
| self.default_snapshot_attrs: dict = { |
nerdai
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
This looks good from my perspective, though I definitely don't have full context.
I added some commentary about raise NotImplementedError in an abstractmethod of a class that inherits from ABC. Hope it clears it up -- my bad for the confusion as I too was a bit confused :)
emersodb
reviewed
Jan 24, 2025
emersodb
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[Feature]
Short Description
Clickup Ticket(s): https://app.clickup.com/t/8688wzkuk , https://app.clickup.com/t/860qxm622
Integrated an early stopping module as a plug-in for all clients. After a specified number of training steps, the module computes the evaluation loss. If the loss improves compared to previous evaluations, it saves a snapshot of the model's key attributes, enabling the model to restore these attributes when the stopping criteria are met.
Tests Added
Added a series of tests for snapshot modules to ensure they are saved and loaded correctly as intended.