Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assert statements out of run_smoke_test and into the actual test (for graceful shutdown in case of failure) #318

Merged
merged 31 commits into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
2046b24
mv assertions outside of run_smoke_tests
nerdai Jan 23, 2025
a65329c
add workflow_dispatch trigger for testing
nerdai Jan 23, 2025
8dfe3a7
get rid of ALL assert used in and raise Custom exception instead
nerdai Jan 23, 2025
a2490f1
add verbose flag
nerdai Jan 23, 2025
aead025
change scope to session
nerdai Jan 23, 2025
e8e6d5e
use module instead of session, should still work the same
nerdai Jan 23, 2025
a2cdef1
subset of tests, to test cleanup
nerdai Jan 23, 2025
4b8ebc9
cleanup func
nerdai Jan 23, 2025
2635e79
smaller subset
nerdai Jan 23, 2025
f898bc7
wip
nerdai Jan 23, 2025
6399c72
test entire
nerdai Jan 23, 2025
6eee21b
handle TimeoutError
nerdai Jan 23, 2025
32ef5b1
add cancel cleanup
nerdai Jan 23, 2025
f166d74
unlock all
nerdai Jan 23, 2025
157e18b
rm workflow_dispatch trigger
nerdai Jan 23, 2025
c527c05
clean up getting output from stdout
nerdai Jan 24, 2025
8962e33
working
nerdai Jan 24, 2025
94ab853
add comment
nerdai Jan 24, 2025
69afc0b
test on runner
nerdai Jan 24, 2025
c095753
add retry for flaky test
nerdai Jan 24, 2025
810dd30
removed unnecessary event_loop from tests
nerdai Jan 24, 2025
ab8d3a7
cr
nerdai Jan 24, 2025
f6d3cea
rm workflow_dispatch
nerdai Jan 24, 2025
01fdbd2
use function scope
nerdai Jan 24, 2025
643ed0d
add workflow_dispatch to test function scope
nerdai Jan 24, 2025
791ca2d
rm workflow_dispatch
nerdai Jan 24, 2025
9a5b0e1
revert back to module
nerdai Jan 24, 2025
6d2ea4a
add graceful shutdown of processes
nerdai Jan 24, 2025
d61fc5c
comment
nerdai Jan 24, 2025
1e9b944
increase attempts of flaky test
nerdai Jan 24, 2025
5c5576c
rm workflow_dispatch
nerdai Jan 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/smoke_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ jobs:
- name: Run Script
run: |
source .venv/bin/activate
pytest -m "smoketest"
pytest -m "smoketest" -v
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,3 @@ markers = [
"smoketest: marks tests as smoke tests (deselect with '-m \"not smoketest\"')",
]
asyncio_default_fixture_loop_scope = "session"
asyncio_mode = "auto"
Loading
Loading