Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to query DB files using sqlite #7

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

amrit110
Copy link
Member

PR Type ([Feature | Fix | Documentation | Test])

Feature

Short Description

  • This PR adds support to query offline DB files.

Tests Added

  • Added tests to tests/cycquery/test_orm.py

@amrit110 amrit110 self-assigned this Dec 13, 2023
@amrit110 amrit110 added the enhancement New feature or request label Dec 13, 2023
Copy link
Collaborator

@dhanesh-vector dhanesh-vector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #7 (c8f5c66) into main (a227009) will decrease coverage by 0.25%.
The diff coverage is 69.76%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   83.60%   83.35%   -0.25%     
==========================================
  Files          17       17              
  Lines        1873     1887      +14     
==========================================
+ Hits         1566     1573       +7     
- Misses        307      314       +7     
Files Coverage Δ
cycquery/base.py 97.14% <100.00%> (ø)
cycquery/util.py 91.79% <100.00%> (ø)
cycquery/post_process/gemini.py 0.00% <0.00%> (ø)
cycquery/orm.py 90.36% <64.70%> (-3.72%) ⬇️

Impacted file tree graph

@amrit110 amrit110 merged commit 1f03ebb into main Dec 13, 2023
4 of 6 checks passed
@amrit110 amrit110 deleted the add_support_for_db_file branch December 13, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants