Refactor dataset.py to use standard practices. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@amrit110 |
|
Wow just went through it. This is a great piece of refactor @Adibvafa! Kudos. |
for more information, see https://pre-commit.ci
|
Thank you @amrit110! I also added tests to make sure the refactor is valid. It's good to merge now, please take a look! |
amrit110
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
Short Description
The dataset.py uses redundant classes, methods, and parameters. This PR will refactor the dataset creation principles used in this repository to be modular and follow standard practices.
Tests Added
Add tests for dataset.py