Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also load config using WithEnvLiteralLoader #4000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Also load config using WithEnvLiteralLoader #4000

wants to merge 2 commits into from

Conversation

predictiple
Copy link
Contributor

No description provided.

@scudette
Copy link
Contributor

scudette commented Jan 8, 2025

This will break existing functionality. Why don't you add another env variable to use for literal config?

@predictiple
Copy link
Contributor Author

predictiple commented Jan 9, 2025 •
edited
Loading

Ok I've done that. It seems a bit strange though, but I guess we can't assume nobody's using the existing env var.

It also means the tests are a bit inconsistent because they read the literal config from the existing env var.

@predictiple predictiple changed the title Change env loader to use WithEnvLiteralLoader Also load config using WithEnvLiteralLoader Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@predictiple @scudette