Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle extra "Send text message" challenge page #1150

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

edwardrf
Copy link
Contributor

It seems some times google will present an extra "Send text message" challenge page that requires the user to click on the button to actually get text message sent and present the code input in the next page.

#1137

@lionello
Copy link

@mapkon can you check?

@mapkon
Copy link
Contributor

mapkon commented Oct 24, 2023

@mapkon can you check?

@edwardrf Thank you for these changes. Do you mind adding some tests to this?

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #1150 (e71898b) into master (4ac5dca) will increase coverage by 0.10%.
Report is 2 commits behind head on master.
The diff coverage is 43.75%.

❗ Current head e71898b differs from pull request most recent head 4cb136a. Consider uploading reports for the commit 4cb136a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage   39.09%   39.20%   +0.10%     
==========================================
  Files          53       53              
  Lines        7977     7993      +16     
==========================================
+ Hits         3119     3134      +15     
+ Misses       4444     4442       -2     
- Partials      414      417       +3     
Flag Coverage Δ
unittests 39.20% <43.75%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/provider/googleapps/googleapps.go 27.90% <43.75%> (+1.79%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

It seems some times google will present an extra "Send text message"
challenge page that requires the user to click on the button to actually
get text message sent and present the code input in the next page.
@edwardrf
Copy link
Contributor Author

edwardrf commented Nov 2, 2023

@mapkon sorry for the delay, just added the test case, plz take a look.

@edwardrf
Copy link
Contributor Author

edwardrf commented Nov 3, 2023

@mapkon i've updated the test case that wasn't functioning correctly due to automatic html formatting, plz take a look again.

@mapkon
Copy link
Contributor

mapkon commented Nov 3, 2023

@mapkon i've updated the test case that wasn't functioning correctly due to automatic html formatting, plz take a look again.

Thanks buddy! I will take a look

@mapkon mapkon linked an issue Nov 4, 2023 that may be closed by this pull request
@mapkon mapkon merged commit b56d607 into Versent:master Nov 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMS never sent when login with GoogleApp provider
4 participants