Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] remove redirect to about:blank page #1164

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

eliat123
Copy link
Contributor

Solves #1161

Background:

The code change that was introduced in https://github.com/Versent/saml2aws/pull/1157/files#diff-5cd59a5a8d31c61bb9c035ee3524699cd8e97b722683501d805074f7d11b7ee9R102-R103

was done because of a signature change with the new release:
https://github.com/playwright-community/playwright-go/blob/main/page.go#L567

The cb method is not an error callback, but a general callback which is not mandatory:

https://github.com/playwright-community/playwright-go/blob/ddc7abdd06db016d63664de1ab08870195085ddb/waiter.go#L144

The issue

The redirect to blank page created an unwanted side-effect that did not allow saml2aws to continue with AWS role selection as described in #1161.

This is the fix.

FYI @gliptak

@eliat123 eliat123 changed the title remove redirect to about:blank page [Bug fix] remove redirect to about:blank page Nov 14, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0b61e6e) 39.22% compared to head (14a1f34) 39.24%.

Files Patch % Lines
pkg/provider/browser/browser.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
+ Coverage   39.22%   39.24%   +0.01%     
==========================================
  Files          53       53              
  Lines        8025     8022       -3     
==========================================
  Hits         3148     3148              
+ Misses       4455     4452       -3     
  Partials      422      422              
Flag Coverage Δ
unittests 39.24% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gliptak gliptak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting my understanding of updated behaviour and working through this @eliat123

@mapkon
Copy link
Contributor

mapkon commented Nov 14, 2023

CC: @gliptak

@gliptak
Copy link
Contributor

gliptak commented Nov 14, 2023

👍

@mapkon mapkon merged commit 47feda6 into Versent:master Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to login using SAML 2.0 federated users to access the AWS Management Console due to recent change.
5 participants