Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print roles with list-roles #1172

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

blackliner
Copy link
Contributor

@blackliner blackliner commented Dec 1, 2023

We use list-roles in a wraper script to gather the available okta accounts. I think skipping the output is not properly placed in this function call, because the intention of it is to actually list them, not do any shortcuts. Hence I removed this check for only one list, as I do not see why it should behave differently in this case.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a9a16c7) 39.26% compared to head (f3e5743) 39.28%.

Files Patch % Lines
cmd/saml2aws/commands/list_roles.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   39.26%   39.28%   +0.02%     
==========================================
  Files          53       53              
  Lines        8030     8025       -5     
==========================================
  Hits         3153     3153              
+ Misses       4454     4449       -5     
  Partials      423      423              
Flag Coverage Δ
unittests 39.28% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon mapkon merged commit 8c57a29 into Versent:master Dec 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants