Fix broken link #1372
Open
Fix broken link #1372
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Background The link that comes up when using the `--provider` flag is broken. ```sh $ saml2aws login --provider=Ping The --provider flag has been replaced with a new configure command. See https://github.com/versent/saml2aws/v2#adding-idp-accounts ``` ## Detail Corrected https://github.com/versent/saml2aws/v2#adding-idp-accounts link to https://github.com/Versent/saml2aws#configuring-idp-accounts . ## Additional info The adding-idp-accounts document has been renamed to configuring-idp-accounts with this change. Versent@7bbdacc#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L71 Also consistent with what we have here. https://github.com/Versent/saml2aws/blob/64255ff7019612e60de7b5139206f1c514cf4374/README.md?plain=1#L212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The link that comes up when using the
--providerflag is broken.Detail
Corrected https://github.com/versent/saml2aws/v2#adding-idp-accounts link to https://github.com/Versent/saml2aws#configuring-idp-accounts .
Additional info
The adding-idp-accounts document has been renamed to configuring-idp-accounts with this change.
7bbdacc#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L71
Also consistent with what we have here.
saml2aws/README.md
Line 212 in 64255ff