Add the time when it will expire to debug log #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikutas
force-pushed
the
when_will_it_expire
branch
from
aba4cb6 to
1eb5eed
Compare
sledigabel
reviewed
Jan 19, 2022
pkg/awsconfig/awsconfig.go
Outdated
| @@ -113,13 +113,13 @@ func (p *CredentialsProvider) Load() (*AWSCredentials, error) { | |||
| } | |||
|
|
|||
| // Expired checks if the current credentials are expired | |||
| func (p *CredentialsProvider) Expired() bool { | |||
| func (p *CredentialsProvider) Expired() (bool, *time.Time) { | |||
There was a problem hiding this comment.
The function name doesn't really do what it says now.
Why not create a new method ExpiresAt to return the *time.Time instead?
mikutas
force-pushed
the
when_will_it_expire
branch
from
f25bb11 to
7b9add7
Compare
sledigabel
reviewed
Jan 20, 2022
pkg/awsconfig/awsconfig.go
Outdated
| @@ -122,6 +122,15 @@ func (p *CredentialsProvider) Expired() bool { | |||
| return time.Now().After(creds.Expires) | |||
| } | |||
|
|
|||
| func (p *CredentialsProvider) ExpiredAt() *time.Time { | |||
There was a problem hiding this comment.
I would recommend passing it as value, since a time.Time is a measure of Time.
There was a problem hiding this comment.
Just noticed 👀, can we perhaps use previousCreds.Expires instead of adding ExpiredAt?
There was a problem hiding this comment.
@mikutas that is indeed a lot simpler :-)
|
FWIW, LGTM! 🚀 |
mikutas
force-pushed
the
when_will_it_expire
branch
from
8d48e13 to
08656cf
Compare
|
@mapkon please rebase |
Do you want me to merge this? |
|
yes please consider merging. @mikutas found this useful for debugging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want to know when to expire even if credentials are not expired for now ?