Use the same output for surveys as for logs. #884
Conversation
Add a package variable to hold the survey output writer and a setter for it. Add a helper to generate a survey option using the writer for stdout. Initialize the survey output to be the same as for the log module.
|
One thing I forgot to note: The |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #884 +/- ##
==========================================
- Coverage 39.11% 39.09% -0.02%
==========================================
Files 53 53
Lines 7973 7977 +4
==========================================
Hits 3119 3119
- Misses 4440 4444 +4
Partials 414 414
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
There was a problem hiding this comment.
Merging this will bump our test coverage down. Could you please consider adding tests?
I think that any tests that could be added in this PR would be primarily performative, instead of, for example, being used to spot regressions in future PRs. From what I can tell, the survey module is not conducive to test writing to begin with.
| ) | ||
|
|
||
| // outputWriter is where for all prompts will be printed. Defaults to os.Stder. |
There was a problem hiding this comment.
Nit: typo
| // outputWriter is where for all prompts will be printed. Defaults to os.Stder. | |
| // outputWriter is where for all prompts will be printed. Defaults to os.Stderr. |
Add a package variable to hold the survey output writer and a setter for it.
Add a helper to generate a survey option using the writer for stdout.
Initialize the survey output to be the same as for the log module.
Fixes #883 .