Added identity init to CoupledRationalQuadraticSpline #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentStimper
approved these changes
Nov 30, 2023
|
@vincentberenz I think there is another error caused by the Python version here. Can you have a look, please? |
|
@mattcleigh The failure of the test was likely not caused by your PR, but by a problem with the test itself. @vincentberenz is looking into this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Initializing the flow as an identity transform is exceptionally useful for training and is supported by the classes in the
wrapper.pyfile such asAutoregressiveRationalQuadraticSplineCircularAutoregressiveRationalQuadraticSplineandCircularCoupledRationalQuadraticSplinebut notCoupledRationalQuadraticSplineSolution
Added
init_identitytoCoupledRationalQuadraticSplinein a way that is consistent with the other classes.