-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Song Creation form is not sufficiently user friendly #305 #820
Song Creation form is not sufficiently user friendly #305 #820
Conversation
Merge main into SongCreationForm
VocaDbWeb/Views/Shared/KnockoutPartials/_CoverArtistMessage.cshtml
Outdated
Show resolved
Hide resolved
Merge main into songCreationForm
To resolve the Appveyor build error
Add _CoverArtistMessage
@Pyther99 Deployed on the beta site. |
@dset0x The markup parsing error occurred because the description was missing a space between ### and the text. I have fixed the side warnings to the vertical center of the viewport, but this can cause the warnings to overlap if there are enough duplicates. (This worsened the responsiveness for mobile devices and needs to be fixed in the future, see #6) I also implemented a Bootstrap tooltip for the artist warning. |
@Pyther99 That's awesome, thanks for tending to these. If it worked better on mobile without the fixed location, a workaround could be to only enable that using Yet another minor thing. Not everyone is familiar with the initials "PV". "Promotional Video" might also be misleading though. Not sure what the best option is. |
@dset0x The width was reduced in the last commit, which is not yet deployed on the beta site. Nevertheless, I still shortened the width a little. |
Thanks for the PR! |
Depends on #817.
Closes VocaDB/community#85.
Closes VocaDB/community#51.
Partially implements VocaDB/community#94. (Romanization link)
Implementation of @dset0x's patch for the song creation page.
Needs to be tested on the beta site.