Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song Creation form is not sufficiently user friendly #305 #820

Merged
merged 37 commits into from
Apr 15, 2021
Merged

Song Creation form is not sufficiently user friendly #305 #820

merged 37 commits into from
Apr 15, 2021

Conversation

FinnRG
Copy link
Member

@FinnRG FinnRG commented Mar 31, 2021

Depends on #817.
Closes VocaDB/community#85.
Closes VocaDB/community#51.
Partially implements VocaDB/community#94. (Romanization link)

Implementation of @dset0x's patch for the song creation page.

Needs to be tested on the beta site.

FinnRG added 3 commits April 4, 2021 15:08
Merge main into songCreationForm
To resolve the Appveyor build error
@FinnRG FinnRG marked this pull request as ready for review April 4, 2021 13:22
@ycanardeau ycanardeau changed the base branch from main to feat/305-song-creation-form April 7, 2021 11:47
@ycanardeau
Copy link
Contributor

@Pyther99 Deployed on the beta site.

@dset0x
Copy link
Collaborator

dset0x commented Apr 8, 2021

@Pyther99 Fantastic work turning the mockup into a functioning page already! It's so cool to see this on the beta site.

I wrote some feedback in this screenshot,
song_submit_feedback

@FinnRG
Copy link
Member Author

FinnRG commented Apr 8, 2021

@dset0x The markup parsing error occurred because the description was missing a space between ### and the text.

I have fixed the side warnings to the vertical center of the viewport, but this can cause the warnings to overlap if there are enough duplicates. (This worsened the responsiveness for mobile devices and needs to be fixed in the future, see #6)

I also implemented a Bootstrap tooltip for the artist warning.

@dset0x
Copy link
Collaborator

dset0x commented Apr 8, 2021

@Pyther99 That's awesome, thanks for tending to these.

If it worked better on mobile without the fixed location, a workaround could be to only enable that using @media, but I can't say how bad that might be.

Yet another minor thing. Not everyone is familiar with the initials "PV". "Promotional Video" might also be misleading though. Not sure what the best option is.

@hikaruso
Copy link

hikaruso commented Apr 9, 2021

@Pyther99 I think the width of the label in the title input field should be increased.
It doesn't look good in the Japanese UI because the labels are vertical.
Web キャプチャ_9-4-2021_195452_beta vocadb net_

@ycanardeau ycanardeau added frontend Presentation layer (visible to user) content: songs Song entries labels Apr 9, 2021
@dset0x
Copy link
Collaborator

dset0x commented Apr 10, 2021

Looking at the current beta site, it feels a bit awkwardly long now,
image
But if it needs to be so that translations fit better, then it's no issue

@FinnRG
Copy link
Member Author

FinnRG commented Apr 10, 2021

@dset0x The width was reduced in the last commit, which is not yet deployed on the beta site. Nevertheless, I still shortened the width a little.
localhost_44398_Song_Create (3)

@ycanardeau
Copy link
Contributor

Thanks for the PR!

@ycanardeau ycanardeau merged commit 3418012 into VocaDB:feat/305-song-creation-form Apr 15, 2021
@ycanardeau ycanardeau mentioned this pull request Apr 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content: songs Song entries frontend Presentation layer (visible to user)
Projects
None yet
4 participants