-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events update #43
Events update #43
Conversation
Your Render PR Server URL is https://documentation-pr-43.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-co6tf9acn0vc73aro3eg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you address the notes, then lgtm
source/events/interaction-events.md
Outdated
--- | ||
|
||
# Supported MouseEvents (in XR and 2D) | ||
|
||
## `touchend` | ||
These are standard MouseEvents and _should_ behave as they would on any webpage. | ||
|
||
Triggered whenever the controller's trigger button or pinch gesture is released, or when the user stops touching an entity. | ||
## `click` | ||
|
||
Origin: the target element | ||
## `mouseover` | ||
|
||
## `mouseout` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be its own event page instead of being hidden at the bottom - just adding the file in the folder directly should update the section on the left so there's nothing more involved to do other than that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also make sure to add the same sections like you did for the above interaction items
description
origin:
detail:
- ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah then I might leave these undocumented, we don't add any more detail to them than the standard MouseEvents implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we will in a future update when I refactor the ControlSystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good -then this isnt a pr blocker, just leave them without the descriptions, but on a new page still- and make an open issue in the documentation repo as a reminder for when we get to that ~
Updated documentation to reflect new update events.