remove unnecessary 'relativepath' warning/error case for html links #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking
...
Problem
we were 'warn/erroring' on path links that were valid but relative, even if the file was able to load properly
Solution
allow for relative links
Breaking Change
nope
Notes
before, we're getting a lot of unnecessary warnings:
![Screenshot 2024-05-16 at 2 16 34 PM](https://private-user-images.githubusercontent.com/19377312/331387179-d8693245-9477-4fed-94ee-0d23dbfb575e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNjkzMzgsIm5iZiI6MTczOTE2OTAzOCwicGF0aCI6Ii8xOTM3NzMxMi8zMzEzODcxNzktZDg2OTMyNDUtOTQ3Ny00ZmVkLTk0ZWUtMGQyM2RiZmI1NzVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA2MzAzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2OTQ3NzU0NGQzZGJmYjUxN2ZhOGMyYmIwM2RmY2ZkMGNhNTAxYmQ3NGQzOTRlZDJjZDdjN2FhNzcwMDkxMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qn8fFhC4JESBh5tCewTUEf5U8hixprgZPsm-AUw625g)
now we're no longer getting those warnings:
![Screenshot 2024-05-16 at 2 17 07 PM](https://private-user-images.githubusercontent.com/19377312/331387281-52060daa-8ea6-4f8e-9b0f-416baa792aa3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNjkzMzgsIm5iZiI6MTczOTE2OTAzOCwicGF0aCI6Ii8xOTM3NzMxMi8zMzEzODcyODEtNTIwNjBkYWEtOGVhNi00ZjhlLTliMGYtNDE2YmFhNzkyYWEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA2MzAzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0YmI5NzY0NTQwOWQ1MGVkMmY3ZmY2ODMxNGZjMGVjNzk2OGFlNzM5NDFjN2Q2NWRiNGExNTNiZjRkMDdkZTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9-rmKoa64a7ftN-ptLOI1od3n2CUEV1_fRlN-wgKgG4)
Required to Merge
[ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.[ ] BREAKING CHANGE@lobau
@hanbollar