Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary 'relativepath' warning/error case for html links #665

Merged
merged 2 commits into from
May 16, 2024

Conversation

hanbollar
Copy link
Contributor

Linking

...

Problem

we were 'warn/erroring' on path links that were valid but relative, even if the file was able to load properly

Solution

allow for relative links

Breaking Change

nope

Notes

before, we're getting a lot of unnecessary warnings:
Screenshot 2024-05-16 at 2 16 34 PM

now we're no longer getting those warnings:
Screenshot 2024-05-16 at 2 17 07 PM


Required to Merge

  • PASS - all necessary actions must pass (excluding the auto-skipped ones)
  • TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
  • [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.
  • TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
  • [ ] BREAKING CHANGE
    • DOCUMENTATION: This includes any changes to html tags and their components
      • make a pr in the documentation repo that updates the manual docs to match the breaking change
      • link the pr of the documentation repo here: #pr
      • that pr must be approved by @lobau
    • SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
      • make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
      • link the pr of the landing page repo here: #pr
      • that pr must be approved by @hanbollar

Copy link

render bot commented May 16, 2024

@hanbollar hanbollar changed the title remove unnecessary 'relativepath' warning/error case remove unnecessary 'relativepath' warning/error case for html links May 16, 2024
Signed-off-by: hanbollar <[email protected]>
@hanbollar hanbollar merged commit dd5138e into main May 16, 2024
6 checks passed
@hanbollar hanbollar deleted the hb-fix-paths branch May 16, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant