Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: filter items to just arsenal items and skins #15

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Create a find function that only contains items for arsenal and skins while also merging the requested language with the item to remove the need for the i18n object


Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Enhancement

@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner September 26, 2024 23:01
@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) September 26, 2024 23:03
src/Utils.js Outdated Show resolved Hide resolved
Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some docs, i think

@SlayerOrnstein SlayerOrnstein merged commit 6147471 into WFCD:main Sep 27, 2024
9 checks passed
@SlayerOrnstein SlayerOrnstein deleted the data-cleanup branch September 27, 2024 01:33
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants