Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get weapon skin from warframe-items if possible #9

Merged
merged 1 commit into from
May 11, 2024

Conversation

SlayerOrnstein
Copy link
Member

@SlayerOrnstein SlayerOrnstein commented May 11, 2024

What did you fix?

Adds the skins item data from warframe-items only if it exist

{
	"uniqueName": name,
	"item": Item
}

I was gonna have the Item override the whole object but I realized those would by annoying for typed languages i.e.

// Before
class Skin {
	final String uniqueName;
  	final String? category;
    final String? description;
    final String? excludeFromCodex;
    final String? imageName;
    final String? masterable;
    final String? name;
    final String? tradable;
    final String? type;
}

// After
class Skin {
    final String uniqueName;
	final Item? item;
}

class Item {
	final String category;
    final String description;
    final String excludeFromCodex;
    final String imageName;
    final String masterable;
    final String name;
    final String tradable;
    final String type;
}

Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Feature

@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner May 11, 2024 03:25
@TobiTenno TobiTenno merged commit 8308ea7 into WFCD:main May 11, 2024
8 checks passed
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants