Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OpenMP for simplifying thread setup in fire particle animations (master branch) #1561

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

epsilon-0
Copy link
Contributor

Notice: Wayfire's development is temporarily happening in the stabilize-api branch. If you open a pull request for the master branch, it will likely not be merged before the stabilize-api branch is itself merged into master.

@epsilon-0 epsilon-0 force-pushed the openmp-master branch 2 times, most recently from f0d19b2 to 7021a4b Compare August 31, 2022 11:50
@ammen99
Copy link
Member

ammen99 commented Oct 21, 2022

LGTM, can you rebase on top of master to get the CI working, too?

@epsilon-0
Copy link
Contributor Author

updated.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the CI still doesn't pass.

@ammen99
Copy link
Member

ammen99 commented Sep 23, 2023

Ping

@epsilon-0
Copy link
Contributor Author

Fixed!

@epsilon-0 epsilon-0 requested a review from ammen99 November 10, 2023 22:16
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I will merge after the 0.8.1 release to avoid adding new dependencies for a minor release.

@ammen99 ammen99 merged commit 6ed5b78 into WayfireWM:master Mar 13, 2024
4 checks passed
@epsilon-0 epsilon-0 deleted the openmp-master branch March 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants