Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animate: Fix crash when unloading plugin during animation #2055

Closed
wants to merge 1 commit into from

Conversation

soreau
Copy link
Member

@soreau soreau commented Dec 7, 2023

Fixes #670.

@ammen99
Copy link
Member

ammen99 commented Dec 20, 2023

This change doesn't make much sense. We explicitly want to clean up the running animations of views not any output when unloading the plugin (we need to clean up everything in this case anyway), and your proposed change will just ignore views not on any output - but if they have any pending animations, we should remove them for sure.

I suspect the actual bug is somewhere else, we probably destroy the views when removing the animation from them. Likely it would help to get the views from core, make them into shared pointers (so that they are alive as long as the function runs), remove all transformers (the shared_ptr will keep them alive) and then they will be freed once the function has finished running.

@ammen99
Copy link
Member

ammen99 commented Mar 4, 2024

Superseded by #2142

@ammen99 ammen99 closed this Mar 4, 2024
@ammen99 ammen99 deleted the fix-animate-unload-crash branch March 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New weird crash: reloading animation plugin while window close animation is playing
2 participants