Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-loader: refuse loading plugins with no metadata #2562

Closed
wants to merge 1 commit into from
Closed

plugin-loader: refuse loading plugins with no metadata #2562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/core/plugin-loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,19 @@ void wf::plugin_manager_t::reload_dynamic_plugins()
continue;
}

auto config_section = wf::get_core().config.get_section(plugin_name);
if (config_section == nullptr)
{
LOGE(plugin_name,
" has no configuration, skipping. "
"Usual reasons for this include missing or outdated plugin XML files, "
"or mismatch between the versions of Wayfire and wf-config. "
"Make sure that you have the correct versions of all relevant packages and make sure that there ",
"are no conflicting installations of Wayfire using the same prefix. "
"Note that if this plugin was newly installed, you need to restart Wayfire before using it.");
continue;
}

next_plugins.push_back(plugin_path.value());
} else
{
Expand Down
Loading