-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor animation duration config UI #84
Refactor animation duration config UI #84
Conversation
Requires WayfireWM/wf-config#71 |
The PR seems to work ok, but my only nitpick is cosmetic. I would like to retain the order of the combobox of easings as I had it: EDIT: |
I also noticed the bug back then and even tried to fix it but I didn't find out how. I'll look into that again and share my thoughts. |
As other easings will be available the order will change however. As I understand your point is that easings should be sorted by "complexity", right? |
I wanted to use the order listed in wf-config here. |
Okay, but I think it doesn't really matter for user then? They're sorted in alphabetical order in |
It matters to me, I would rather retain the ordering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it actually fixed a bug where the easing was defaulting to linear with the reset-to-defaults button. Thank you for addressing the easing ordering in the combobox. You can you merge this when you're ready. 👍
Thanks! I think it's ready, but I don't have write access to this repo. |
Related to #80