Fix int and animation option writes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NamorNiradnug I know this seems a bit convoluted, but I was hoping you might be able to help improve upon it. |
Trying to set int or animate options does not work when typing them into the spin button field. Scrolling and clicking the tick boxes to change the value does, however. Apparently, this is a problem with gtkmm when calling get_value_as_int() in the changed handler. It does not affect double options, which use get_value(). This solution uses the C API to work around the problem.
|
I have been testing this and it seems to be an improvement, so merging before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to set int or animate options does not work when typing them into the spin button field. Scrolling and clicking the tick boxes to change the value does, however. Apparently, this is a problem with gtkmm when calling get_value_as_int() in the changed handler. It does not affect double options, which use get_value(). This solution uses the C API to work around the problem.