install.sh: Add the ability to use doas if it is present, instead of sudo #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for all of the git troubles with both of my PRs, I am still learning git. |
wb9688
suggested changes
Jul 21, 2024
install.sh
Outdated
| if [[ -z "$(command -v doas)" ]]; then | ||
| SUDO=doas | ||
| fi | ||
|
|
||
| # Usually we use sudo, but if prefix is somewhere in ~/, we don't need sudo | ||
| SUDO=sudo |
There was a problem hiding this comment.
The former won't do anything, because SUDO is set to sudo here anyway.
There was a problem hiding this comment.
I think the changes I made just now should be good.
kernaltrap8
force-pushed
the
install-sh-patches
branch
3 times, most recently
from
7581698 to
5a88bde
Compare
Signed-off-by: kernaltrap <[email protected]>
kernaltrap8
force-pushed
the
install-sh-patches
branch
from
5a88bde to
741cc4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may not use or even have sudo available to them, and because of this, the install script breaks trying to remove
startwayfireor add it, I'm not too sure. But once I had sudo installed, the script worked fine.