Update: refactor code

Wayoung7 · Mar 22, 2024 · d3201fd · d3201fd
1 parent 3b8f482
commit d3201fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/bin/firework/gen.rs b/src/bin/firework/gen.rs
@@ -5,7 +5,7 @@ use glam::Vec2;
 use rand::{seq::IteratorRandom, thread_rng, Rng};
 
 pub fn dyn_gen(fm: &mut FireworkManager, width: u16, height: u16, enable_gradient: bool) {
-    let colors = vec![
+    let colors = [
         vec![
             (255, 102, 75),
             (144, 56, 67),

diff --git a/src/bin/firework/main.rs b/src/bin/firework/main.rs
@@ -33,7 +33,7 @@ fn main() -> Result<()> {
     let mut is_running = true;
     let cli = Cli::parse();
     if let Some(f) = cli.fps {
-        if f < 5 || f > 30 {
+        if !(5..=30).contains(&f) {
             return Err(Error::new(
                 std::io::ErrorKind::Other,
                 "Invalid fps value! Valid fps range: 5~30",