Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow dapps to specify config for exporting private keys #1916

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Sep 2, 2024

Motivation and Context

Allowing dapps to specify that they want to enable private key export or not.

Jira Link: https://toruslabs.atlassian.net/browse/PD-3834

Description

  • Fetch the project config from dashboard and set it accordingly in the provider.
  • Allow the dapps to enable/disable it via config setting.
  • default value is true, hence allows exporting of private keys

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 4836ccf into v9 Sep 2, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/disable-private-key-export branch September 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants