Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formalize component value definitions #336
formalize component value definitions #336
Changes from 7 commits
4400af7
42cb5fe
d2f1335
76cb955
b58579e
dc2859f
88e6d8f
1747d40
d63fa29
3cd3dc8
0c9a3d4
54d551f
5098ffc
5a349e3
7c0c34f
c3f309b
b8c31b0
82a66f8
2c77edb
a56e792
ba58e56
6c8e7b4
c557391
043b923
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might need to be
(char v)
in the text format?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(although text-wise it's probably nicer to have
(char "x")
rather than(char 0x61)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is actually to use
'x'
syntax (seeExplainer.md
), I agree that current rule definition seems to be insufficient to express that, but I'm not sure how to correctly express that and whether it actually belongs in the rule or simply as a note below. @lukewagner what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To some degree this is running up against limitations of the text format I think because
'x'
isn't a valid or defined token in the text format in the same way Rust defines'x'
and"x"
. That could be added here, however, but as-is I don't believe it can be assumed to exist already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be addressed now?