Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and Features - VBG, Comments, Guest Endpoint #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adamweeks
Copy link
Contributor

@adamweeks adamweeks commented May 24, 2024

Lots of changes in this PR, it is best to go commit by commit.

@adamweeks adamweeks changed the title fix: remove guest endpoint check Improvements and Features - VBG, Comments, Guest Endpoint May 31, 2024
Copy link
Collaborator

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Rest looks good.

Comment on lines +12 to +13
<script type="module" type="text/javascript" src="index.js"></script>
<script type="module" type="text/javascript" src="webex.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it standard to put these scripts after the body tag so that it can read all elements just in case we have some DOM queries before window.onload?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants