Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README images to reflect UI updates. #697

Closed
wants to merge 2 commits into from
Closed

Updated README images to reflect UI updates. #697

wants to merge 2 commits into from

Conversation

Aem1024
Copy link
Contributor

@Aem1024 Aem1024 commented Dec 10, 2023

No description provided.

JoshuaBrest
JoshuaBrest suggested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@JoshuaBrest JoshuaBrest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problems

README.md
@@ -7,12 +7,12 @@
[![](https://img.shields.io/discord/1115955071549702235?style=for-the-badge)](https://discord.gg/CsqAfs9CnM)
</div>

<img width="650" alt="Screenshot 2023-03-31 at 17 14 00" src="https://user-images.githubusercontent.com/42140194/229232488-dbad85f4-cecb-45e1-a182-f737fe9d2b1f.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using a personal github repo.

README.md

Familiar UI that integrates seamlessly with macOS

<div align="right">
<img width="650" alt="Screenshot 2023-03-31 at 17 14 22" src="https://user-images.githubusercontent.com/42140194/229232557-07f78a79-f695-45f6-be45-15a5b2f3c053.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here

JoshuaBrest
JoshuaBrest suggested changes Dec 18, 2023
View reviewed changes
images/NewBottle.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The window in the image is the wrong aspect ratio. Yours is 259:129, it should be 2:1. To fix this, delete the file at ~/Library/Preferences/com.isaacmarovitz.Whisky.plist then relaunch whisky. It should open at the default window size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBrest JoshuaBrest JoshuaBrest requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aem1024 @JoshuaBrest @IsaacMarovitz