Image hook styled #131
Draft
Image hook styled #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JoshuaRogan
commented
Oct 2, 2019
•
JoshuaRogan
commented
- Update readme
- Write tests
- Test code
vforge
reviewed
Oct 2, 2019
| Click the theme buttons to re-initialize examples. | ||
|
|
||
| ```js | ||
| <StyledCountdown onTick={value => console.log("Countdown: ", value)} /> |
vforge
reviewed
Oct 2, 2019
| @@ -0,0 +1,101 @@ | |||
| import React, { useState } from 'react'; | |||
There was a problem hiding this comment.
We use React.useState, let's drop this import
vforge
reviewed
Oct 2, 2019
| setIsLimbo(true); | ||
| }, [src]); | ||
| // this is odd but it allows us to quickly flush the src when an image src is swapped but react is able to use | ||
| // the same DOM element. The other option would be to use keys but then react can't be as efficient. |
JoshuaRogan
force-pushed
the
image-hook-styled
branch
from
a3ec7ed to
bbce9a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.