PLATFORM-5397: Update Reverb #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLATFORM- fix hook name
PLATFORM-8233 fix: Notifications options got weirdly reset between two GP wikis
The assets should not have /extensions-ucp/v1 url.
The assets should not have /extensions-ucp/v2 in url. It should be replaced with /extensions-ucp/mw139/
The assets should not have /extensions-ucp/v2 in url. It should be replaced with /extensions-ucp/mw139/ (code style fix)
UXFCP-3645 (fix): Removed wrong assets url from notification user_note
Avoid the following: ``` TypeError from line 26 of /extensions/Reverb/src/Notification/NotificationBroadcastFactory.php: Reverb\Notification\NotificationBroadcastFactory::new(): Argument #3 ($targets) must be of type array, User given, called in /extensions/Reverb/src/ReverbBroadcastHookHandler.php on line 513 #0 /extensions/Reverb/src/ReverbBroadcastHookHandler.php(513): Reverb\Notification\NotificationBroadcastFactory->new(string, User, User, array) #1 /extensions/Reverb/src/ReverbBroadcastHookHandler.php(460): Reverb\ReverbBroadcastHookHandler->sendNotificationsForEdit(User, Title, RecentChange) #2 /includes/libs/rdbms/database/Database.php(2501): Reverb\ReverbBroadcastHookHandler->Reverb\{closure}(integer, Wikimedia\Rdbms\DatabaseMysqli) #3 /includes/libs/rdbms/loadbalancer/LoadBalancer.php(1869): Wikimedia\Rdbms\Database->runOnTransactionIdleCallbacks(integer, array) #4 /includes/libs/rdbms/lbfactory/LBFactory.php(469): Wikimedia\Rdbms\LoadBalancer->runPrimaryTransactionIdleCallbacks(string) #5 /includes/libs/rdbms/lbfactory/LBFactory.php(424): Wikimedia\Rdbms\LBFactory->executePostTransactionCallbacks() #6 /includes/deferred/DeferredUpdates.php(476): Wikimedia\Rdbms\LBFactory->commitPrimaryChanges(string) #7 /includes/deferred/DeferredUpdates.php(399): DeferredUpdates::attemptUpdate(MWCallableUpdate, Fandom\Includes\Database\FandomLoadBalancerFactory) #8 /includes/deferred/DeferredUpdates.php(214): DeferredUpdates::run(MWCallableUpdate, Fandom\Includes\Database\FandomLoadBalancerFactory, Monolog\Logger, Fandom\Includes\Util\SalvageableBufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string) #9 /includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer) #10 /includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure) #11 /includes/deferred/DeferredUpdates.php(235): DeferredUpdatesScope->processUpdates(integer, Closure) #12 /includes/MediaWiki.php(1104): DeferredUpdates::doUpdates() #13 /includes/MediaWiki.php(838): MediaWiki->restInPeace() #14 /includes/MediaWiki.php(587): MediaWiki->doPostOutputShutdown() #15 /index.php(50): MediaWiki->run() #16 /index.php(46): wfIndexMain() ```
1. Fixed counter of notifications 2. Tab "All" is working properly 3. "Mark all read" also changing from Unread tab to Read
When messages were dismissed and user: 1. wants to go to next page, just refresh current paging (so will not miss n notifications) 2. wants to go to the last page (i.e. 4) but after dismissals only 3 pages are available we direct him to page3 and refersh apginator to not show non-existent pages 3. and want to go into some page in the middle (dismissed some on page 1, have 10 pages of notifications and want to go to page 2-9) we allow this and we move user to requested page This is not ideal, but we are here in conflict of interests: Cause when You dismiss a message (read/unread) it stays in Your viewport so You could change Your mind. But this creates an issue with "Scrolling window" in old version if we dismiss 4 messages (D) and click go to page 2 You will loose preview on 4 messages (message 11-14) beacuse when server responded with new list it starts counting from M5 as first not-dismissed page 1: D1 D2 D3 D4 M5 M6 M7 M8 M9 M10 page 2: M15 M16 ... M24 Loading and poping additional messages to existing page on dismissal might be option for future, but in such case You will end up with L (loaded on dismissal messages ) which will make messages window to grow to 14 messages on current page in our example, see below: page 1: D1 D2 D3 D4 M5 M6 M7 M8 M9 M10 L11 L12 L13 L14 page 2: M15 M16 ... M24
1. Fixed counter of notifications 2. Tab "All" is working properly 3. "Mark all read" also changing from Unread tab to Read 4. Fixed filter All not checked not to show any of notifications
Uxfcp 3554 fix: Reverb is displaying number of notifications correctly
PLATFORM-8565 | Remove two-version deployments for prod environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLATFORM-5397: Cleanup namespaces in WikiDomains
https://fandom.atlassian.net/browse/PLATFORM-5397