Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: users.jsp should be accessible to orgAdmins #987

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

holmbergius
Copy link
Contributor

Investigating why users.jsp went from orgAdmin-level access requirement to admin. This simple change restores expected behavior.

@holmbergius holmbergius self-assigned this Jan 19, 2025
@holmbergius holmbergius marked this pull request as ready for review January 24, 2025 05:45
@holmbergius holmbergius requested a review from naknomum January 24, 2025 05:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.13%. Comparing base (5e90e87) to head (f279c86).

Additional details and impacted files
@@           Coverage Diff           @@
##              main    #987   +/-   ##
=======================================
  Coverage     0.13%   0.13%           
  Complexity      29      29           
=======================================
  Files          573     573           
  Lines        63628   63628           
  Branches     11024   11024           
=======================================
  Hits            89      89           
  Misses       63520   63520           
  Partials        19      19           
Flag Coverage Δ
backend 0.13% <ø> (ø)
frontend 0.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naknomum naknomum merged commit 4c6aff1 into main Jan 31, 2025
1 check passed
@naknomum naknomum deleted the re-relax-admin-to-orgadmin branch January 31, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants