-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Custom Foreign Keys #53
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. For this to truly not be a breaking change, the current value passed along to the I would also prefer naming the const |
Thank you. After I've finished making the changes mentioned above I'll mark this as ready for review. Leaving as draft until then. |
@mattmcdonald-uk I've made the requested changes and marked this ready. Please review when you get a chance, thanks. |
If you would prefer, I'm not opposed to opening a new Pr as a single commit. I've resisted squashing too much here, so that the conversation would be easier to follow. |
I've overlooked the fact the the Listeners are all using |
@mattmcdonald-uk it's ready! |
If anyone is interested in trying out this feature, you can do so by temporarily adding the fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/inmanturbo/Laravel-Userstamps.git"
}
]
} Then update your dependency constraint to reference this branch by running: composer require wildside/userstamps:dev-patch-1 |
Hey there! This PR adds support for custom foreign keys.
For instance if someone needs to use a uuid but it's not the key on the model.
This will make it easier to track userstamps across distributed systems.
In our case users are in a seperate database from most resources. Users have a ulid column specifically for relationships outside of the Auth domain, and for showing links where we won't show the auto-incremented id, which is used internally within the Auth domain.
This isn't a breaking change because it uses the default by default
Usage