Pull request #83: Sync the insertion point menu order with the 14.2 f…

…ront end. Merge in PAC/chatbook from bugfix/454247-for-ChatNotebooks to main * commit '4429770ff48574282d29f6a8413a0a2bb2ee3a91': Replace "Side Chat" with "Chat Break" in chat notebook's insertion menu. Sync the insertion point menu order with the 14.2 front end.
WolframResearch · Nov 19, 2024 · 91e08e4 · 91e08e4
2 parents f2e5b06 + 4429770
commit 91e08e4
Show file tree

Hide file tree

Showing 9 changed files with 163 additions and 114 deletions.
diff --git a/Developer/StylesheetBuilder.wl b/Developer/StylesheetBuilder.wl
@@ -573,29 +573,71 @@ $chatDelimiterCellDingbat   = Wolfram`Chatbook`UI`MakeChatDelimiterCellDingbat[
 (* ::Subsection::Closed:: *)
 (*Cell Insertion Point Cell*)
 
-$cellInsertionPointCell := $cellInsertionPointCell = ReplaceAll[
-    FrontEndResource[ "FEExpressions", "CellInsertionMenu" ],
-    {
-        PaneSelectorBox[
-            args: {
-                True -> StyleBox[
-                    DynamicBox[ FEPrivate`FrontEndResource[ "CellInsertionMenu", "TextStyle2Mac" ], ___ ],
-                    ___
-                ],
-                ___
-            },
-            True|False,
-            opts___
-        ] :> PaneSelectorBox[ args, Dynamic[ $OperatingSystem === "MacOSX" ], opts ]
-        ,
-        item: HoldPattern[ _ :> FrontEndTokenExecute[ EvaluationNotebook[ ], "Style", "ExternalLanguage" ] ] :>
-            Sequence[
-                item,
-                insertionPointMenuItem[ TemplateBox[ { }, "ChatInputIcon" ], trBox[ "StylesheetInsertionMenuChatInput" ], "'", "ChatInput" ],
-                insertionPointMenuItem[ TemplateBox[ { }, "SideChatIcon" ], trBox[ "StylesheetInsertionMenuSideChat" ], "''", "SideChat" ]
-            ]
-    }
-];
+
+(*
+The cell structures used by the cell insertion point cell in the 14.2 FE are
+significantly different than in 14.1 and earlier FEs. Also note that 14.2 FEs
+already have chat-related styles in its insertion menu, so this menu re-ordering
+and additions won't be necessary starting in 14.2.
+
+Because of that, when the code below is run in 14.2 or later FEs,
+$cellInsertionPointCell will be set to Inherited. And the 14.1-specific code can
+be very particular about what the boxes actually look like.
+*)
+
+
+$cellInsertionPointCell := $cellInsertionPointCell = 
+If[BoxForm`sufficientVersionQ[14.2], Inherited,
+	ReplaceAll[
+		reorderAndAddMenuItems[ FrontEndResource[ "FEExpressions", "CellInsertionMenu" ] ],
+		{
+			PaneSelectorBox[
+				args: {
+					True -> StyleBox[
+						DynamicBox[ FEPrivate`FrontEndResource[ "CellInsertionMenu", "TextStyle2Mac" ], ___ ],
+						___
+					],
+					___
+				},
+				True|False,
+				opts___
+			] :> PaneSelectorBox[ args, Dynamic[ $OperatingSystem === "MacOSX" ], opts ]
+	    }
+	]
+]
+
+
+reorderAndAddMenuItems[boxexpr_] :=
+ReplaceAll[ boxexpr, ActionMenuBox[label_, items_, rest___] :> 
+	ActionMenuBox[
+		label,
+		Replace[items, 
+			{
+				input:    (_ :> FrontEndTokenExecute[EvaluationNotebook[], "Style", "Input"]),
+				Delimiter,
+				washort:  (_ :> FrontEndTokenExecute[EvaluationNotebook[], "Style", "WolframAlphaShort"]),
+				walong:   (_ :> FrontEndTokenExecute[EvaluationNotebook[], "Style", "WolframAlphaLong"]),
+				ext:      (_ :> FrontEndTokenExecute[EvaluationNotebook[], "Style", "ExternalLanguage"]),
+				Delimiter,
+				text:     (_ :> FrontEndTokenExecute[EvaluationNotebook[], "Style", "Text"]),
+				other:    (_ :> FrontEndTokenExecute[EvaluationNotebook[], "StyleOther"])
+			}  :>
+			{
+				input,
+				text,
+				other,
+				Delimiter,
+				insertionPointMenuItem[ TemplateBox[ { }, "ChatInputIcon" ], trBox[ "StylesheetInsertionMenuChatInput" ], "'", "ChatInput" ],
+				insertionPointMenuItem[ TemplateBox[ { }, "SideChatIcon" ], trBox[ "StylesheetInsertionMenuChatBreak" ], "~", "ChatDelimiter" ],
+				Delimiter,
+				washort,
+				walong,
+				ext
+			}
+		],
+		rest
+	]
+]
 
 
 insertionPointMenuItem // Attributes = { HoldRest };