feat: improve setting ui in UI.wl, add OpenAi Chat Completion URL settings #456
Conversation
Now you can change default endpoint to anything you want
|
This seems like a good idea. Two small changes to make for consistency:
|
|
Sorry, I was confused when I looked at the CI checking, did the engine in the docker image have a problem with the license?
This is the screenshot from when I ran it on my local machine
|
Don't worry about that, it was my mistake. I approved the CI/CD actions for your PR, but I wasn't considering the fact that it sourced from your forked repository instead of the WolframResearch/Chatbook repository. Your forked repository just isn't configured with the necessary GitHub secrets to run those workflows, hence the errors. You can safely ignore those. |
There was a problem hiding this comment.
This looks great, though there are a few changes we'd like before merging (see comments).
Also, you may have noticed in the code that there are two paths for submitting the chat request, depending on whether LLMServices is available (here and here). In 14.0+, the LLMServices method will be the way that requests are submitted, so your changes wouldn't have any affect in future versions. However, I think this is still definitely a useful feature for 13.3 users.
) and ) ```txt This seems like a good idea. Two small changes to make for consistency: Do not change the gitignore file Please use "OpenAI" with capital I instead of "OpenAi" and "API" with all capital instead of "API" everywhere. ``` Co-authored-by: Rick Hennigan <[email protected]>
WolframResearch#456 (comment) Use `find Source/ -type f -exec sed -i 's/OpenAiApiCompletionURL/OpenAIAPICompletionURL/g' {} +` to minimize the change that missing something
|
If you have time can you consider checking my newest fix 🤗 |
|
@nhannht I think this looks good and ready to merge, but I realized that this repository was missing the standard contributor notice used in other Wolfram repositories. I just added it here. Can you take a moment to read that and just confirm here that you agree with the "Licensing of Contributions" part? I'll go ahead and merge this once you confirm. |
|
Thank you, I tried to read all 3 links, I can grasp at least a basic. (to be honest, this is the first time I have tried to read these kind of documents 😄) I understood and agreed with all the terms below : |
Hello, this repo is pretty big, I try not to mess with the current code base but if I do something wrong, feel free to fix it if you have time
There are typical cases in which the user didn't fetch data from the official OpenAi url but from some kind of proxy, that is why I added this minor change.
By default, the official URL will be used, but now people can freely change it to something else like
http://localhost:8080/v1/chat/completions/.