Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Nuxt #5319

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update dependency Nuxt #5319

merged 1 commit into from
Jan 6, 2025

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 6, 2025

Description

While trying to fix the build problems in the Storybook update PRs, I found that Nuxt version mismatch causes some problems, so updating Nuxt to the latest version here. I don't know why Renovate did not open Nuxt PR.

Testing Instructions

The CI should pass, and the app should work as usual

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 402      ✗ 0   
     data_received..................: 94 MB   390 kB/s
     data_sent......................: 52 kB   217 B/s
     http_req_blocked...............: avg=32.79µs  min=2.28µs   med=4.39µs   max=351.5µs  p(90)=149.25µs p(95)=167.22µs
     http_req_connecting............: avg=20.18µs  min=0s       med=0s       max=294.12µs p(90)=96.73µs  p(95)=114.39µs
     http_req_duration..............: avg=152.74ms min=16.53ms  med=108.5ms  max=1s       p(90)=330.44ms p(95)=422.27ms
       { expected_response:true }...: avg=152.74ms min=16.53ms  med=108.5ms  max=1s       p(90)=330.44ms p(95)=422.27ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 402 
     http_req_receiving.............: avg=157.07µs min=62.45µs  med=133.9µs  max=505.79µs p(90)=253.44µs p(95)=325.78µs
     http_req_sending...............: avg=23.21µs  min=9.11µs   med=21.18µs  max=91.72µs  p(90)=37µs     p(95)=41.16µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=152.56ms min=16.44ms  med=108.32ms max=1s       p(90)=330.28ms p(95)=421.96ms
     http_reqs......................: 402     1.670882/s
     iteration_duration.............: avg=825.09ms min=290.74ms med=913.83ms max=1.71s    p(90)=1.1s     p(95)=1.39s   
     iterations.....................: 75      0.311732/s
     vus............................: 0       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat marked this pull request as ready for review January 6, 2025 14:52
@obulat obulat requested a review from a team as a code owner January 6, 2025 14:52
@obulat obulat requested review from krysal and dhruvkb January 6, 2025 14:52
@obulat obulat merged commit af2a2fd into main Jan 6, 2025
48 checks passed
@obulat obulat deleted the update/nuxt branch January 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants