Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish localization support to Openverse #5352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yashhhYB
Copy link

@yashhhYB yashhhYB commented Jan 24, 2025

Fixes

Description

  • Added Spanish language file (es.json).
  • Updated supported locales to include Spanish.
  • Implemented a language selector in the header component.
  • Verified that all strings translate correctly for Spanish.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Add Spanish localization support to Openverse
@yashhhYB yashhhYB requested a review from a team as a code owner January 24, 2025 10:04
@yashhhYB yashhhYB requested review from obulat and dhruvkb January 24, 2025 10:04
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 24, 2025
@dhruvkb
Copy link
Member

dhruvkb commented Jan 24, 2025

@yashhhYB is this fixing an open issue on Openverse? If not a rationale for the PR would be helpful.

Also I've restored the PR template in your PR description. Please populate the placeholders in the template, instead of replacing it with a freeform description.

@openverse-bot openverse-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Jan 24, 2025
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🌟 goal: addition Addition of new feature 📄 aspect: text Concerns the textual material in the repository 💻 aspect: code Concerns the software code in the repository and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
Status: 👀 Needs Review
Development

Successfully merging this pull request may close these issues.

3 participants